core/gtk: allow editing Ghostty config in a Ghostty window#11905
Open
jcollie wants to merge 4 commits intoghostty-org:mainfrom
Open
core/gtk: allow editing Ghostty config in a Ghostty window#11905jcollie wants to merge 4 commits intoghostty-org:mainfrom
jcollie wants to merge 4 commits intoghostty-org:mainfrom
Conversation
jcollie
force-pushed
the
edit-config-new-window
branch
from
e8abc94 to
8479d1e
Compare
This PR extends the `open_config` keybind action to allow editing the Ghostty config in a new Ghostty window using the editor configured in `$EDITOR` or `$VISUAL`.
jcollie
force-pushed
the
edit-config-new-window
branch
from
37f1b3c to
db7d050
Compare
Member
|
I am not sure I am convinced of this PR.
|
Member
Author
|
The main thing that this PR brings over running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the
open_configkeybind action to allow editing the Ghostty config in a new Ghostty window using the editor configured in$EDITORor$VISUAL.