Conversation
…TestPreview Agent-Logs-Url: https://github.com/gfauredev/LogOut/sessions/0f6378fd-9596-4c0b-ad61-8ca333b9a78d Co-authored-by: gfauredev <19304085+gfauredev@users.noreply.github.com>
…n test files Agent-Logs-Url: https://github.com/gfauredev/LogOut/sessions/0f6378fd-9596-4c0b-ad61-8ca333b9a78d Co-authored-by: gfauredev <19304085+gfauredev@users.noreply.github.com>
…ms before router strips them Agent-Logs-Url: https://github.com/gfauredev/LogOut/sessions/8b56abd0-c183-4283-afd6-4eb71b62c82b Co-authored-by: gfauredev <19304085+gfauredev@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
gfauredev
April 8, 2026 06:30
View session
📊 Coverage ReportLines: 3754/5005 (75.004995004995%) ⏱️ Tests: 255 tests in 0.568s
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes Lighthouse and web E2E from CI. Moves them to CD, triggered after each successful Pages deploy. Fixes the web E2E test suite so all 20 Maestro flows pass locally via
nix run .#webE2eTest.Key changes
CI/CD pipeline (
ci.yml,cd.yml)e2e-weband Lighthouse jobs from CIpagespeedjob to CD: calls PageSpeed Insights API on the live preview URL after each Pages deploye2e-web-previewjob to CD: runs Maestro flows against the live preview URL after each Pages deploy (screenshot upload commented out)Nix (
flake.nix)serverandwebE2eTestfrom thedefaultpackage (not needed for plain builds)webStaticServerpackage: a Python SPA server that serves the WASMwebpackage at/LogOut/with SPA fallback anddatabase.example/at/db/— same origin, no CORSwebE2eTestnow useswebStaticServerinstead of the SSR-onlyserverbinary (which had no WASM and caused all client-side assertions to fail)webE2eTestPreviewfor running flows against a deployed URLDeep-link query param fix (
src/main.rs,src/utils.rs)Dioxus's
WebHistory::new()callshistory.replaceStateduring init, stripping?dl_db_url=…/?dl_session=…fromwindow.locationbeforeDeepLinkLayout.use_hookcan read them.Fix: capture
window.location.searchinApp()— which runs before theRoutermounts — into a newInitialQuerySignalcontext.DeepLinkLayoutreads deep-link params from this preserved string via the newparse_web_deep_link_query(query: &str)helper.Maestro flows (
maestro/web/)http://localhost:8080with${APP_URL}/${APP_URL_ENCODED}and${DB_URL}/${DB_URL_ENCODED}env-var referencesdl_db_url→dl_db_url=${DB_URL_ENCODED}in exercise-DB deep links (separate concern from the app URL)en.ftl:search-placeholder = Search exercises names or attributesEngineering Principles
scope is focused (no unrelated dependency updates or formatting)
README's Engineering PrinciplesCI/CD Readiness
feat/…,fix/…,refactor/…, …dx fmt; cargo fmtnix flake checkssucceeds without warningsdx buildwith necessary platform flags succeedscargo clippy -- -D warnings -W clippy::all -W clippy::pedanticproduces zero warnings
cargo llvm-cov nextest --ignore-filename-regex '(src/components/|\.cargo/registry/|nix/store)'maestro test --headless maestro/webmaestro test --headless maestro/android