Conversation
…fic asset bundling Agent-Logs-Url: https://github.com/gfauredev/LogOut/sessions/e5a25fad-19c7-4453-a825-a538c2380143 Co-authored-by: gfauredev <19304085+gfauredev@users.noreply.github.com>
Agent-Logs-Url: https://github.com/gfauredev/LogOut/sessions/e5a25fad-19c7-4453-a825-a538c2380143 Co-authored-by: gfauredev <19304085+gfauredev@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
gfauredev
April 6, 2026 13:21
View session
📊 Coverage ReportLines: 3751/4953 (75.73187966888756%) ⏱️ Tests: 255 tests in 0.659s
|
❌ Maestro Web E2E Failures📜 Maestro Console Output (Last 100 lines)📸 Screenshots |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four loosely-coupled improvements to the Android release pipeline and Nix build hygiene.
Changes
assets/_unique.scss— gesture navigation pill#main > navis sticky atbottom: 0; without bottom padding it overlaps the Android / iOS gesture bar. Added:padding-bottom: env(safe-area-inset-bottom, 0);Viewport already carries
viewport-fit=cover..script/aab-sign.sh— App Bundle signingNew script parallel to
apk-sign.sh. Key difference:apksigneronly handles APKs; AABs requirejarsigner(available viaopenjdk, already inandroidNativeBuildInputs). Signs withSHA256withRSA/SHA-256digest as required by Google Play upload-key policy. Identical env-var interface (ANDROID_KEYSTORE_PATH,ANDROID_KEYSTORE_PASS,ANDROID_KEY_PASSWORD,ANDROID_KEY_ALIAS).fastlane/metadata/android/{en-US,fr-FR,es-ES}/Standard Fastlane supply layout (
title,short_description,full_description,changelogs/default) in all three app languages. Consumed by both Google Play (fastlane supply) and IzzyOnDroid (same F-Droid/Fastlane metadata convention).flake.nix— target-scoped asset bundlingsw.js,404.html,icon-*.pngdatabase.example/serverAssetFilter/filteredSrcServer: extendsassetFilterto includedatabase.example/**; used only by the.#serverderivation, which now copies the directory into$out/bin/alongside the binary.mkAndroidBuilder: stashes web-only public files beforedx build --androidand restores them unconditionally viatrap EXIT. Usesshopt -s nullglobto avoid iterating over unexpanded globs.Engineering Principles
scope is focused (no unrelated dependency updates or formatting)
README's Engineering PrinciplesCI/CD Readiness
feat/…,fix/…,refactor/…, …dx fmt; cargo fmtnix flake checkssucceeds without warningsdx buildwith necessary platform flags succeedscargo clippy -- -D warnings -W clippy::all -W clippy::pedanticproduces zero warnings
cargo llvm-cov nextest --ignore-filename-regex '(src/components/|\.cargo/registry/|nix/store)'maestro test --headless maestro/webmaestro test --headless maestro/android