Skip to content

feat(sentry-types): Add metric protocol envelope support#1022

Open
szokeasaurusrex wants to merge 1 commit intomasterfrom
szokeasaurusrex/metrics-protocol
Open

feat(sentry-types): Add metric protocol envelope support#1022
szokeasaurusrex wants to merge 1 commit intomasterfrom
szokeasaurusrex/metrics-protocol

Conversation

@szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex commented Mar 2, 2026

Add Metric protocol types and trace_metric envelope container serialization/deserialization in sentry-types.

Closes #1008
Closes RUST-159

@linear
Copy link

linear bot commented Mar 2, 2026

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 670c069

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-protocol branch 2 times, most recently from ee23bf8 to 52b0419 Compare March 2, 2026 17:16
@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review March 2, 2026 17:16
@szokeasaurusrex szokeasaurusrex requested a review from lcian as a code owner March 2, 2026 17:16
cursor[bot]

This comment was marked as resolved.

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-protocol branch from a5a8201 to d53c02f Compare March 4, 2026 14:13
szokeasaurusrex added a commit that referenced this pull request Mar 4, 2026
Add `TraceMetric` protocol types and `trace_metric` envelope container serialization/deserialization in `sentry-types`.

Closes #1008
Closes [RUST-159](https://linear.app/getsentry/issue/RUST-159/add-trace-metric-protocol-models-and-envelope-item-container-support)

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Co-authored-by: Lorenzo Cian <17258265+lcian@users.noreply.github.com>
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-protocol branch from d53c02f to d06efa0 Compare March 4, 2026 14:14
@szokeasaurusrex szokeasaurusrex requested a review from lcian March 4, 2026 14:14
Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

/// A single [trace metric](https://develop.sentry.dev/sdk/telemetry/metrics/).
#[derive(Serialize, Deserialize, Clone, Debug, PartialEq)]
#[non_exhaustive]
pub struct TraceMetric {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's call it Metric.

#[derive(Serialize, Deserialize, Copy, Clone, Debug, PartialEq)]
#[serde(rename_all = "lowercase")]
#[non_exhaustive]
pub enum TraceMetricType {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too.

Add `Metric` protocol types and `trace_metric` envelope container serialization/deserialization in `sentry-types`.

Closes #1008
Closes [RUST-159](https://linear.app/getsentry/issue/RUST-159/add-trace-metric-protocol-models-and-envelope-item-container-support)

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Co-authored-by: Lorenzo Cian <17258265+lcian@users.noreply.github.com>
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-protocol branch from d06efa0 to 670c069 Compare March 10, 2026 12:50
@szokeasaurusrex szokeasaurusrex changed the title feat(sentry-types): Add trace metric protocol envelope support feat(sentry-types): Add metric protocol envelope support (#1022) Mar 10, 2026
@szokeasaurusrex szokeasaurusrex changed the title feat(sentry-types): Add metric protocol envelope support (#1022) feat(sentry-types): Add metric protocol envelope support Mar 10, 2026
@szokeasaurusrex szokeasaurusrex requested a review from lcian March 10, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add trace metric protocol models and envelope item container support

2 participants