feat(nestjs-tools-file-storage): add S3-compatible service support for DigitalOcean Spaces#103
Open
mugabodannyshafi wants to merge 2 commits intogetlarge:mainfrom
Open
Conversation
…r DigitalOcean Spaces **Changes:** - Add endpoint configuration with virtual-hosted-style URLs support - Enhance region extraction to handle DigitalOcean Spaces endpoints - Set forcePathStyle to false for S3-compatible services - Bump package versions across monorepo (file-storage: 1.4.1 → 1.4.2) - Update typed-event-emitter dependency (0.2.0 → 0.2.1) This enables the file-storage package to work with S3-compatible services like DigitalOcean Spaces by properly configuring endpoint URLs and region extraction from non-AWS S3 endpoints.
getlarge
reviewed
Nov 14, 2025
Owner
getlarge
left a comment
getlarge
left a comment
There was a problem hiding this comment.
Thanks for your contribution, I have one question.
Comment on lines
+43
to
+48
| ...(endpoint | ||
| ? { | ||
| endpoint, | ||
| forcePathStyle: false, // Use virtual-hosted-style URLs (required for DigitalOcean Spaces) | ||
| } | ||
| : {}), |
Owner
There was a problem hiding this comment.
How can we be sure this won't affect other endpoint for regular S3 usage?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
This enables the file-storage package to work with S3-compatible services like DigitalOcean Spaces by properly configuring endpoint URLs and region extraction from non-AWS S3 endpoints.