Fix Node 24 readline regression in updatedb.js#277
Closed
unicomp23 wants to merge 1 commit intogeoip-lite:mainfrom
airtimemedia:fix/node24-readline-regression
Closed
Fix Node 24 readline regression in updatedb.js#277unicomp23 wants to merge 1 commit intogeoip-lite:mainfrom airtimemedia:fix/node24-readline-regression
unicomp23 wants to merge 1 commit intogeoip-lite:mainfrom
airtimemedia:fix/node24-readline-regression
Conversation
Replace `for await` loops on readline with event-based readline to avoid ERR_USE_AFTER_CLOSE error on Node 24.2+ when processing files with >1025 lines. See: nodejs/node#60507 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
!!! DO NOT DELETE THIS PR/BRANCH !!!
Used by eureka until node24 gets fixed.
Replace
for awaitloops on readline with event-based readline to avoid ERR_USE_AFTER_CLOSE error on Node 24.2+ when processing files with >1025 lines.See: nodejs/node#60507
🤖 Generated with Claude Code