Add series option to support GeoIP2 premium database#265
Open
face wants to merge 4 commits intogeoip-lite:mainfrom
Open
Add series option to support GeoIP2 premium database#265face wants to merge 4 commits intogeoip-lite:mainfrom
face wants to merge 4 commits intogeoip-lite:mainfrom
Conversation
added 3 commits
April 30, 2024 20:15
vigan-abd
approved these changes
May 1, 2024
bluesmoon
reviewed
May 2, 2024
| }); | ||
| if (typeof series === 'undefined' && typeof process.env.GEODBSERIES !== 'undefined') { | ||
| series = process.env.GEODBSERIES; | ||
| } else if (typeof series !== 'undefined') { |
Collaborator
There was a problem hiding this comment.
can you move the else if to a new line?
bluesmoon
reviewed
May 2, 2024
| series = series.slice('series='.length); | ||
| } | ||
| if (typeof series === 'undefined') { | ||
| series = 'GeoLite2' |
Collaborator
There was a problem hiding this comment.
check indentation on these lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package works great with the more accurate GeoIP2 files, with the following option added to updatedb.js: license=xxxx series=GeoIP2 (where license is subscribed to the premium data).