feat(ask): extensible check type registry#895
Merged
geoffjay merged 8 commits intoissue-870-2from Mar 29, 2026
Merged
Conversation
Add GET /questions and GET /questions/:id API endpoints to the ask service, with corresponding client methods and CLI subcommands. - Add ListQuestionsQuery and ListQuestionsResponse types - Add get_all_questions() and get_questions_by_status() to AppState - Add GET /questions[?status=] and GET /questions/:id handlers in api.rs - Add list_questions() and get_question() methods to AskClient - Add 'agentd ask list [--status]' and 'agentd ask get <id>' CLI subcommands - Fix broken CLI test: update TriggerResults field from tmux_sessions to checks
Add 15 new integration tests covering the list/get endpoints, check
registry behaviour, full trigger->list->answer flow, and AskClient
methods exercised against a live in-process router.
Also fix the /questions/{id} route syntax (Axum v0.8 uses {param} not
:param) and repair the pre-existing test that asserted tmux_sessions
appeared in checks_run when the registry was empty.
Owner
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Mar 29, 2026
test(ask): expand integration test coverage
feat(ask): list endpoint for questions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(ask): extensible check type registry
feat(ask): extensible check type registry (#872)