Conversation
geoffjay
added
the
review-agent
…ard fields The Native and Polling fields are intentional drop-guards: they keep the watcher alive (or cancel the polling task) purely via their Drop impl. Add #[allow(dead_code)] with an explanatory doc comment.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 13 unit tests for
FileWatchStrategy(construction with eachWatchMode, polling detection of create/modify/delete, glob pattern filtering, event-kind filtering, debounce, shutdown, object safety) and 5 tests forTriggerConfig::FileWatch(serde roundtrip, minimal defaults, polling mode deserialization,trigger_type(),is_implemented(),is_one_shot()). Also fixes glob validation to run before spawning the polling task (fail-fast).Closes #813