Raise error when both password and key_file are provided#15
Merged
Conversation
Co-authored-by: gensyn <36128035+gensyn@users.noreply.github.com> Agent-Logs-Url: https://github.com/gensyn/ssh_command/sessions/5ab62ef3-b3b0-453f-be28-8e9642eafc4c
Copilot
AI
changed the title
[WIP] Fix issue with password and key file resulting in no error
Raise error when both password and key_file are provided
Mar 25, 2026
…and-key-file-error
Owner
|
@copilot Please fix the unit tests that broke in this branch. |
Co-authored-by: gensyn <36128035+gensyn@users.noreply.github.com> Agent-Logs-Url: https://github.com/gensyn/ssh_command/sessions/e7e48fd7-44bc-4678-9965-fa84aeff7366
Contributor
Author
Fixed in 9ef8835. After a merge, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Providing both
passwordandkey_filesilently succeeded using the password, with no indication that the conflicting inputs were ignored. This adds an explicit validation error when both are supplied.Changes
__init__.py): Added apassword_and_key_filecheck after the existing "neither provided" guardstrings.json,translations/en.json,translations/de.json): Added the newpassword_and_key_fileerror keytest_validate_service_data.py): Addedtest_password_and_key_file_raisesREADME.md): Updated validation rules to reflect the mutual exclusivity ofpasswordandkey_fileOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.