feat: add git:// support to IDL v2 includes#1272
Merged
vobradovich merged 5 commits intomasterfrom Mar 31, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for fetching IDL files from git repositories during the preprocessing stage. It refactors the IdlLoader trait to support multiple loaders and adds a GitLoader implementation that handles git:// URLs. The preprocess function now accepts a slice of loaders, allowing for extensible IDL sourcing from both local files and remote repositories. I have no feedback to provide.
438c229 to
29cdcad
Compare
vobradovich
reviewed
Mar 30, 2026
vobradovich
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.