Skip to content

feat: add git:// support to IDL v2 includes#1272

Merged
vobradovich merged 5 commits intomasterfrom
feat/git-include
Mar 31, 2026
Merged

feat: add git:// support to IDL v2 includes#1272
vobradovich merged 5 commits intomasterfrom
feat/git-include

Conversation

@m62624
Copy link
Copy Markdown
Member

@m62624 m62624 commented Mar 30, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for fetching IDL files from git repositories during the preprocessing stage. It refactors the IdlLoader trait to support multiple loaders and adds a GitLoader implementation that handles git:// URLs. The preprocess function now accepts a slice of loaders, allowing for extensible IDL sourcing from both local files and remote repositories. I have no feedback to provide.

@m62624 m62624 force-pushed the feat/git-include branch from 438c229 to 29cdcad Compare March 30, 2026 11:45
@m62624 m62624 marked this pull request as ready for review March 30, 2026 11:55
@m62624 m62624 requested a review from vobradovich March 30, 2026 12:12
@vobradovich vobradovich merged commit b5d73f0 into master Mar 31, 2026
4 checks passed
@vobradovich vobradovich deleted the feat/git-include branch March 31, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants