fix(ethexe-network): Do not dial ourselves

[ark0f]

Also keep network identity in TestEnv across start and stops

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
ethexe/network/src/lib.rs	24% smaller
ethexe/service/src/tests/utils/env.rs	20% smaller
ethexe/network/src/validator/discovery.rs	17% smaller
ethexe/network/src/slots.rs	0% smaller

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the network stability and testing reliability of the ethexe-network. The primary goal is to prevent nodes from attempting to connect to themselves during discovery and to ensure that network identities remain consistent during test cycles, which helps avoid unnecessary connection attempts and potential state inconsistencies.

Highlights

• Prevent Self-Dialing: Updated the network discovery logic to explicitly filter out the local validator's own address, preventing the node from attempting to dial itself.
• Network Identity Persistence: Modified TestEnv to persist the network identity across node restarts by storing the network_public_key within the Node struct.
• Transport Configuration: Refactored TransportType handling to allow for more granular control over mDNS and slot backoff periods in test environments.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gshep]

Awesome! 🔥

[gemini-code-assist]

Warning

Gemini is experiencing higher than usual traffic and was unable to create the review. Please try again in a few hours by commenting /gemini review.