fix(ethexe-compute): Fix subservices do not wake#5264
Conversation
Changed Files
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where subservices were failing to wake up when new work was submitted. By introducing explicit Waker management and updating the polling logic, the services now correctly register their wakers and resume execution when new data is available, improving the responsiveness and reliability of the compute pipeline. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request implements manual waker management across the CodesSubService, ComputeSubService, and PrepareSubService components. By capturing the Waker from the asynchronous context during poll_next and triggering it within the various receive methods, the services now correctly signal the executor to resume polling when new data is available. Corresponding unit tests have been added to each service to verify that receiving new inputs successfully wakes the pending tasks. I have no feedback to provide.
No description provided.