Skip to content

fix(ethexe-compute): Fix subservices do not wake#5264

Open
ark0f wants to merge 5 commits intomasterfrom
al/ethexe/compute-subservice-wake
Open

fix(ethexe-compute): Fix subservices do not wake#5264
ark0f wants to merge 5 commits intomasterfrom
al/ethexe/compute-subservice-wake

Conversation

@ark0f
Copy link
Copy Markdown
Member

@ark0f ark0f commented Mar 28, 2026

No description provided.

@ark0f ark0f added A0-pleasereview PR is ready to be reviewed by the team D8-ethexe ethexe-related PR labels Mar 28, 2026
@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com bot commented Mar 28, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  ethexe/compute/src/codes.rs  83% smaller
  ethexe/compute/src/prepare.rs  2% smaller
  ethexe/compute/src/compute.rs  0% smaller

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where subservices were failing to wake up when new work was submitted. By introducing explicit Waker management and updating the polling logic, the services now correctly register their wakers and resume execution when new data is available, improving the responsiveness and reliability of the compute pipeline.

Highlights

  • Waker Implementation: Added Waker support to CodesSubService, ComputeSubService, and PrepareSubService to ensure tasks are properly woken when new data arrives.
  • Asynchronous Polling Fix: Updated poll_next implementations to store the waker and return Poll::Pending, ensuring the services correctly react to external events.
  • Regression Testing: Added comprehensive tokio-based tests for each subservice to verify that they are correctly woken upon receiving new inputs.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements manual waker management across the CodesSubService, ComputeSubService, and PrepareSubService components. By capturing the Waker from the asynchronous context during poll_next and triggering it within the various receive methods, the services now correctly signal the executor to resume polling when new data is available. Corresponding unit tests have been added to each service to verify that receiving new inputs successfully wakes the pending tasks. I have no feedback to provide.

Copy link
Copy Markdown
Member

@grishasobol grishasobol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait my review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A0-pleasereview PR is ready to be reviewed by the team D8-ethexe ethexe-related PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants