Fix: Tweak link transformation for absolute paths in source repo#20
Open
Fix: Tweak link transformation for absolute paths in source repo#20
Conversation
❌ Deploy Preview for gardenlinux-docs failed.
|
ByteOtter
force-pushed
the
fix/fix-asset-links
branch
2 times, most recently
from
5344e96 to
0baa0c1
Compare
ByteOtter
force-pushed
the
fix/fix-asset-links
branch
from
0baa0c1 to
4f95e53
Compare
Contributor
|
@ByteOtter Is this ready to review or do we need changes after our last discussions? |
Collaborator
Author
Well it still doesnt work 100 percent so Im gonna continue working on this |
Collaborator
Author
|
obsoleted by #26 from what I can tell |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Tweaks link transformation to deal with absolute paths in source repo for media.
Relative paths have proven to be too flaky for the approach we chose for documentation. I have fixed this manually in the gardenlinux repo by switching to absolute path for media assets in gardenlinux/gardenlinux@c4b1d8d
Which issue(s) this PR fixes:
Fixes n/A
Definition of Done:
main)