Update return type of Singular's hilb, based on singular version#143
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #143 +/- ##
=======================================
Coverage 44.75% 44.75%
=======================================
Files 348 348
Lines 64387 64390 +3
=======================================
+ Hits 28814 28816 +2
- Misses 35573 35574 +1
🚀 New features to boost your workflow:
|
| # Now get the Hilbert Series | ||
| series := SingularInterface("hilb", [Ig, 1, degs], "intvec"); | ||
|
|
||
| if SingularInterface("int", "system(\"version\")", "int") < 43211 then |
There was a problem hiding this comment.
Is 43211 the version where bigintvec was introduced? Or the version hilb switched to returning a bigintvec?
There was a problem hiding this comment.
The version hilb changed the return type
There was a problem hiding this comment.
To be honest, I try to minimize my time searching through the Singular history, if not urgent enough 😅
I always have the feeling to get completely lost in it
There was a problem hiding this comment.
Fair enough :-) I was just curious anyway. If it works, it works!
|
@lgoettgens thank you for these tweaks! @grahamknockillaree thank you for merging. Would you terribly mind making another HAP release with these in? that'd be amazing, thank you! |
|
Thanks @lgoettgens and @fingolfin for all your help with this. I've just created a release v1.74 |
3 participants
The same as #142, but with a version guard to only apply the change to new enough singular versions.
cc @fingolfin @grahamknockillaree