Dev by gameknife · Pull Request #221 · gameknife/gkNextEngine

gameknife · 2026-01-17T14:55:15Z

No description provided.

…load and cyclic testing

- clean all cpu accelerate tasks before loading

- emmsive

- animated default - auto camera fix - materials max t o16384

- prevent physic kick

gemini-code-assist · 2026-01-17T14:55:48Z

Summary of Changes

Hello @gameknife, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the engine's glTF loading capabilities by introducing a comprehensive robustness testing framework and improving compatibility with various glTF asset features, including WebP textures and emissive materials. It also refines the integration between animation and the physics system, ensuring animated objects behave correctly. Additionally, the changes standardize development workflows through updated documentation and build configurations.

Highlights

glTF Robustness Testing Framework: A new GltfTestRunner class has been introduced to automatically fetch, download, and load glTF sample models from KhronosGroup's glTF-Sample-Assets repository. This framework is enabled via a new command-line option --test-gltf and allows filtering models with --test-gltf-filter.
glTF Loader Enhancements: The glTF loader now supports the EXT_texture_webp extension, increases the MAX_MATERIALS limit, includes EmissiveTextureId in materials, and provides improved handling for various glTF primitive types and unsupported features with informative warnings. The AutoFocusCamera logic has been refined to accurately calculate scene bounds considering node world transforms and dynamically set camera planes.
Animation and Physics Integration: Animation tracks now support PlaySpeed_ for controlling playback direction. Animated nodes and their children recursively update their physics bodies to maintain kinematic consistency. A ClearAllTasks method was added to FCPUAccelerationStructure and Scene::CleanUp for proper task management during scene transitions, and TickAnimation is now enabled by default.
Build System and Documentation Updates: The build system (CMakeLists.txt and vcpkg.json) has been updated to include libwebp and nlohmann-json dependencies. Numerous markdown documentation files have been revised to standardize build and run commands, reflecting current development procedures.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a significant set of features and improvements, primarily focused on enhancing glTF support and rendering capabilities. Key additions include a glTF robustness test runner that automatically downloads and tests models from the Khronos sample repository, support for WebP textures, and handling of emissive textures in the glTF loader and shaders.

The review has identified a critical issue in the emissive material loading logic where emissive strength is not being applied, a high-severity issue in the new glTF test runner that could cause it to hang, and several medium-severity issues related to code style, potential robustness improvements in camera calculations, and minor typos. Overall, this is a valuable contribution that significantly expands the engine's capabilities, and addressing the feedback will improve its correctness and robustness.

gemini-code-assist · 2026-01-17T14:59:56Z

src/Assets/FSceneLoader.cpp

+            // TODO: may impl per pixel mat type
            if (emissive != mat.extensions.end())
            {
                float power = static_cast<float>(emissive->second.Get("emissiveStrength").GetNumberAsDouble());


The power variable, extracted from the KHR_materials_emissive_strength extension, is calculated but never used. The previous implementation used this to scale the emissive color and set the material type to DiffuseLight. This change appears to have broken emissive material handling for materials with emissive strength, as the material's emissive properties are not being correctly applied.

gemini-code-assist · 2026-01-17T14:59:56Z

src/Runtime/GltfTestRunner.cpp

+    case State::Loading:
+        if (engine_->GetEngineStatus() == NextRenderer::EApplicationStatus::Running)
+        {
+            renderTimer_ = 0.0f;
+            currentState_ = State::Rendering;
+        }
+        break;


The test runner's Loading state waits for the engine status to become Running. If a glTF file is valid but causes the engine to crash or hang during loading, the test runner will be stuck in this state indefinitely. It would be more robust to add a timeout to the Loading state. If the engine doesn't become Running within a certain time, the runner should log an error, skip the current model, and proceed to the next one.

gemini-code-assist · 2026-01-17T14:59:56Z

assets/shaders/common/BasicTypes.slang

    public float Reserverd2;
    public float Reserverd3;


There's a typo in Reserverd2 and Reserverd3. It should be Reserved2 and Reserved3 for correctness and consistency. This typo also exists in src/Assets/Material.hpp.

public float Reserved2; public float Reserved3;

gemini-code-assist · 2026-01-17T14:59:56Z

src/Assets/FSceneLoader.cpp

+                if (model.textures[texture].extensions.find("EXT_texture_webp") != model.textures[texture].extensions.end())
+                {
+                     if (model.textures[texture].extensions["EXT_texture_webp"].Has("source"))
+                     {
+                         imageIdx = model.textures[texture].extensions["EXT_texture_webp"].Get("source").GetNumberAsInt();
+                     }
+                }


This block of code for handling the EXT_texture_webp extension can be made more efficient and readable by avoiding repeated lookups. Consider using C++17's if with initializer or storing the result of find to avoid searching the map twice. A similar pattern is repeated on lines 383-389.

if (const auto it = model.textures[texture].extensions.find("EXT_texture_webp"); it != model.textures[texture].extensions.end()) { if (it->second.Has("source")) { imageIdx = it->second.Get("source").GetNumberAsInt(); } }

gemini-code-assist · 2026-01-17T14:59:56Z

src/Assets/FSceneLoader.cpp

+        newCamera.NearPlane = glm::min( radius * 0.5f, 0.2f);
+        newCamera.FarPlane = glm::min( radius * 100.f, 1000.f);


The calculation for NearPlane and FarPlane might not be robust for all scene sizes. For example, newCamera.NearPlane = glm::min( radius * 0.5f, 0.2f); will cap the near plane at a maximum of 0.2, which could be too small for very large scenes, potentially causing precision issues. Similarly, FarPlane is capped at 1000. Consider a more dynamic calculation, for example newCamera.NearPlane = std::max(0.01f, radius * 0.01f); and newCamera.FarPlane = radius * 2.0f; to better adapt to scenes of varying scales.

gemini-code-assist · 2026-01-17T14:59:57Z

src/Assets/Material.hpp

        float Reserverd2;
+        float Reserverd3;


There's a typo in Reserverd2 and Reserverd3. It should be Reserved2 and Reserved3 for correctness and consistency. This typo also exists in assets/shaders/common/BasicTypes.slang.

Suggested change

float Reserverd2;

float Reserverd3;

float Reserved2;

float Reserved3;

gemini-code-assist · 2026-01-17T14:59:57Z

src/Assets/Scene.cpp

                if (track.Time_ > durationMax)
                {
-                    track.Time_ = 0;
+                    track.PlaySpeed_ = -1.0f;
+                }
+                if ( track.Time_ < 0.0f )
+                {
+                    track.PlaySpeed_ = 1.0f;
                }


The animation playback logic has been changed to a ping-pong loop. While this might be intended, it's a significant behavior change from the previous simple loop. If this is not the desired effect for all animations, it might be better to make this behavior configurable per animation track.

gemini-code-assist · 2026-01-17T14:59:57Z

src/Assets/Texture.cpp

                task.GetContext(taskContext);
                textureImages_[taskContext.textureId]->MainThreadPostLoading(mainThreadCommandPool_);
-                //SPDLOG_INFO("{}", taskContext.outputInfo.data());
+                SPDLOG_INFO("{}", taskContext.outputInfo.data());


This SPDLOG_INFO log seems to have been uncommented, possibly for debugging. In a production or final build, this could lead to verbose logging which might be undesirable. Consider changing it to SPDLOG_DEBUG or removing it if it's no longer needed.

Suggested change

SPDLOG_INFO("{}", taskContext.outputInfo.data());

//SPDLOG_INFO("{}", taskContext.outputInfo.data());

gameknife added 13 commits January 15, 2026 09:32

Merge remote-tracking branch 'origin/main' into dev

29c238f

Merge remote-tracking branch 'origin/main' into dev

caac62c

fix gltf pbr texture

8174075

feat: implement glTF robustness test with automated sample asset down…

a4620ed

…load and cyclic testing

fix rapid load scene issue

623e58d

- clean all cpu accelerate tasks before loading

support no indices mesh

b046939

support webp image for spec gltf

087cff7

right parse the emmsive

3d639ff

- emmsive

tweaks for issue gltfs

12e4a7e

- animated default - auto camera fix - materials max t o16384

pingpong animation

a3395f1

- prevent physic kick

kinematic setup with node tree

80bb4f3

doc updated

c324653

Merge branch 'feature/gltf-robustness-test' into dev

3ed3aa4

gemini-code-assist bot reviewed Jan 17, 2026

View reviewed changes

fix for android

963f1fe

gameknife merged commit 31c907e into main Jan 17, 2026
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev#221

Dev#221
gameknife merged 14 commits intomainfrom
dev

gameknife commented Jan 17, 2026

Uh oh!

gemini-code-assist bot commented Jan 17, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jan 17, 2026

Uh oh!

gemini-code-assist bot Jan 17, 2026

Uh oh!

gemini-code-assist bot Jan 17, 2026

Uh oh!

gemini-code-assist bot Jan 17, 2026

Uh oh!

gemini-code-assist bot Jan 17, 2026

Uh oh!

gemini-code-assist bot Jan 17, 2026

Uh oh!

gemini-code-assist bot Jan 17, 2026

Uh oh!

gemini-code-assist bot Jan 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		newCamera.NearPlane = glm::min( radius * 0.5f, 0.2f);
		newCamera.FarPlane = glm::min( radius * 100.f, 1000.f);

	SPDLOG_INFO("{}", taskContext.outputInfo.data());
	//SPDLOG_INFO("{}", taskContext.outputInfo.data());

Conversation

gameknife commented Jan 17, 2026

Uh oh!

gemini-code-assist bot commented Jan 17, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant