Open
Conversation
…u have '=end' as the last line of a file and the file has no final '\n', RubyLex loops forever.
Author
|
I added another fix for an issue I ran into. This fix is from another fork of rtags: https://github.com/pbogdan/rtags/commit/3bbde0872af08f71f99cef5a02999f24b34eb5cf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
parse_full_constant_nameto recurse intoparse_full_constant_nameagain, instead of calling non-existent methodparse_full_constant.Fixes a bug in RubyLex (apparently standing for 12 years) where if you have '=end' as the last line of a file and the file has no final '\n', RubyLex loops forever.
Example: https://github.com/lsegal/yard/raw/0.7.4/benchmarks/generation.rb