This PR properly compiles cython to remove pyximport#399
Draft
AreWeDreaming wants to merge 1 commit intomasterfrom
Draft
This PR properly compiles cython to remove pyximport#399AreWeDreaming wants to merge 1 commit intomasterfrom
AreWeDreaming wants to merge 1 commit intomasterfrom
Conversation
smithsp
approved these changes
Mar 5, 2026
Member
smithsp
left a comment
There was a problem hiding this comment.
If this compiles/builds, then let's merge? Or do we need a dedicated OMFIT branch to test this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This modifies the setup.py to compile the Cython code OMAS uses
Type of Change
Testing
There is a new tests that checks if cython was compiled properly
Pre-Merge Checklist
omas/versionfile0.94.2→0.94.3for bug fixes,0.94.2→0.95.0for new features)Additional Notes