Improved the bottom reaching detection.#1308
Open
hitode909 wants to merge 1 commit intofuturepress:masterfrom
Open
Improved the bottom reaching detection.#1308hitode909 wants to merge 1 commit intofuturepress:masterfrom
hitode909 wants to merge 1 commit intofuturepress:masterfrom
Conversation
These values are floating point in some environments. The scroll position plus the height of the visible area may not exactly match the height of the element. By changing to the calculation formula introduced on MDN, it will correctly determine that you have reached the bottom of the container element. https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollHeight#determine_if_an_element_has_been_totally_scrolled
|
This solves the problem with continuous mode and certain epub documents. Thank you @hitode909 ! |
ctlnwng
added a commit
to Upstatement/epub.js
that referenced
this pull request
Jul 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometime I can't swipe to next chapter on vertical content.
I found that
top < this.container.scrollHeightis always true on that broken situation. For example, top is 2199.99 and this.container.scrollHeight is 2200.epub.js/src/managers/default/index.js
Lines 496 to 501 in 3565e47
According to MDN, these numbers often have a floating decimal point.
In my smartphone(Pixel 6a), certainly screen width is 412.19px and screen height is 790.09px.

I changed the calculation formula introduced on MDN, it will correctly determine that you have reached the bottom of the container element.