Conversation
| request(this.url) | ||
| .then(function (xml) { | ||
| // var directory = new Url(this.url).directory; | ||
|
|
There was a problem hiding this comment.
The main change in section is that instead of loading just the page url, I also load the smil file first and then feed the result into where it loads the main page, in order to append it onto the iframe html.
| item.canonical = canonical(item.href); | ||
|
|
||
| if(manifestItem.properties.length){ | ||
| //KEM: added overlay so can load later in section |
There was a problem hiding this comment.
The change here is to load the smil information from the manifest into the saved list of items that keeps track of the page urls and properties. Now the smil will be associated with the page, and this is used later in section.js when the page is loaded and displayed.
|
|
||
| this.html = []; | ||
| //KEM: assets and urls are where the urls in items from the manifest are replaced by "blobs" | ||
| this.assets = []; |
There was a problem hiding this comment.
There's no changes to resources.js other than beautification, but because the audio files are erroring I think the fix will be in how it replaces the URLs in the replacements() function.
| @@ -1,4 +1,4 @@ | |||
| import {qs, qsa, qsp, indexOfElementNode} from "./utils/core"; | |||
There was a problem hiding this comment.
No changes, this is just beautification modification from my editor.
Note: replacing the smil urls with one less folder reference (getting rid of the ../) made the audio load correctly. Not sure best way to solve this. Should we modify the original files?
1 participant
No description provided.