Conversation
OpenAPIスキーマ更新によりsubjectIdがネストされたsubjectオブジェクトに変更されたため対応 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
OpenAPIスキーマ更新によりfacultyIdがネストされたfacultyオブジェクトに変更されたため対応 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
OpenAPIスキーマ更新により: - subjectIdをsubject.idに変更 - TimetableItemRequest/TimetableItemからroomIdが削除されたため関連UI・ロジックを削除 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
kantacky
requested review from
a team,
Copilot,
hikaru-0602,
kantacky and
masaya-osuga
There was a problem hiding this comment.
Pull request overview
This PR syncs the admin web app with the latest OpenAPI schema generated from dotto-typespec, updating frontend code to match the new response shapes (notably subject / faculty becoming nested objects) and removing timetable room handling.
Changes:
- Update OpenAPI schemas to replace
subjectId/facultyIdwith nestedsubject/facultyobjects in several resources. - Refactor timetable and course-registration UI to use the new nested
subject.idaccess pattern. - Remove timetable room selection/display and stop fetching rooms in timetable pages.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/timetable/TimetableItemTable.tsx | Adjusts timetable rendering for nested subject and removes room column/prop. |
| src/components/timetable/TimetableItemForm.tsx | Removes room selection and updates submit payload accordingly. |
| src/components/subjects/SubjectTable.tsx | Updates faculty display to use nested faculty.id. |
| src/components/course-registrations/CourseRegistrationTable.tsx | Updates subject display to use nested subject.id. |
| src/app/dotto/timetable/page.tsx | Stops fetching rooms for timetable page. |
| src/app/dotto/timetable/new/page.tsx | Stops fetching rooms for new timetable item page. |
| src/app/dotto/timetable/new/NewTimetableItemPageClient.tsx | Removes rooms prop plumbing into the form. |
| src/app/dotto/timetable/TimetablePageClient.tsx | Removes rooms/roomMap usage and updates delete dialog subject access. |
| src/app/dotto/course-registrations/CourseRegistrationsPageClient.tsx | Updates delete dialog subject access to nested subject.id. |
| openapi/openapi.yaml | Updates schemas to nested subject/faculty objects and removes timetable roomId. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the OpenAPI schema from dotto-typespec.
Triggered by: fun-dotto/dotto-typespec@a187430