Open
Conversation
Owner
Author
|
This could be also an opportunity to address #104. |
Codecov Report
@@ Coverage Diff @@
## master #412 +/- ##
==========================================
- Coverage 95.51% 93.16% -2.35%
==========================================
Files 46 47 +1
Lines 557 571 +14
Branches 12 10 -2
==========================================
Hits 532 532
- Misses 25 39 +14
Continue to review full report at Codecov.
|
Contributor
|
If we can separate out the result display part of |
Owner
Author
|
You're right @kusamakura. This is painful lesson in keeping type classes focused on one concern. |
|
Hi guys. Just wondering – any activity on this PR? Seems this functionality is a really nice-to-have one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to allow for custom error messages (#161) and to improve string representations of compound predicates like
type LessEqual[N] = Not[Greater[N]](#49) using a dedicatedShowtype class.First results look promising: