Skip to content

Fixed typos, bumped Cmake Requirements to 3.24, switched to "project("#4

Draft
SyseAdmine wants to merge 1 commit intofritzone:masterfrom
SyseAdmine:SyseAdmine-patch-1
Draft

Fixed typos, bumped Cmake Requirements to 3.24, switched to "project("#4
SyseAdmine wants to merge 1 commit intofritzone:masterfrom
SyseAdmine:SyseAdmine-patch-1

Conversation

@SyseAdmine
Copy link
Copy Markdown

WIP for my project

I am experimenting with your script as an absolute beginner
in Python and CMake.

My source code I'm dealing with is the LibreOffice code base from
https://gerrit.libreoffice.org/core
including translations and helpcontent2 in the first build.

WIP for my project
@SyseAdmine SyseAdmine marked this pull request as draft April 4, 2024 18:45
@Static-Codes
Copy link
Copy Markdown
Contributor

Static-Codes commented Mar 31, 2026

I have addressed some the typos and other inconsistencies in my last pull request here. I am currently working on issue #5

Once this has been solved, I plan on adding more validation, updating the minimum version to CMake 3.5, and adding the dedicated project( command which was added in CMake 3.2.1 per https://cmake.org/cmake/help/latest/command/project.html

Given it has been 2 years since this was addressed, I feel the project has matured to a state where these changes should not cause a merge conflict.

@Static-Codes
Copy link
Copy Markdown
Contributor

WIP for my project

I am experimenting with your script as an absolute beginner in Python and CMake.

My source code I'm dealing with is the LibreOffice code base from https://gerrit.libreoffice.org/core including translations and helpcontent2 in the first build.

I have addressed these issues excluding the version support: #8

Like i mentioned in my previous comment on thread, I was confident this could be done without any merge conflicts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants