Skip to content

[601] Updating K8s#24

Merged
chaco-fl merged 5 commits intomainfrom
639-1
Mar 6, 2026
Merged

[601] Updating K8s#24
chaco-fl merged 5 commits intomainfrom
639-1

Conversation

@chaco-fl
Copy link
Copy Markdown
Contributor

@chaco-fl chaco-fl commented Mar 5, 2026

No description provided.

Copy link
Copy Markdown
Member

@mlissner mlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I assume it's just a copy/paste/tweak from Wiki? If so, we'll find the bugs when we start using it. We'll want to make sure the github PR template is imported too, since it ensures devs have guidance about skipping the deploy if needed.

Is this missing the daemon deploy though? I think they're going with one for their data processing work.

@chaco-fl
Copy link
Copy Markdown
Contributor Author

chaco-fl commented Mar 5, 2026

This looks good to me. I assume it's just a copy/paste/tweak from Wiki? If so, we'll find the bugs when we start using it. We'll want to make sure the github PR template is imported too, since it ensures devs have guidance about skipping the deploy if needed.

Is this missing the daemon deploy though? I think they're going with one for their data processing work.

Yes I used wiki deploy.

I was not sure about the daemon, so I removed.
I will add it back.

@quevon24
Copy link
Copy Markdown
Member

quevon24 commented Mar 5, 2026

Yes, we'll use the daemon approach. There's already a draft PR that implements it. If you need it, it can be merged, it has placeholders in the management command where blackletter goes: #23

@chaco-fl
Copy link
Copy Markdown
Contributor Author

chaco-fl commented Mar 5, 2026

I have updated the deployment to include daemon

I also updated the current deploy to be named scanning-web and scanning-daemon

https://github.com/freelawproject/kubernetes/pull/68

@mlissner @quevon24

@chaco-fl chaco-fl requested a review from mlissner March 5, 2026 22:36
@mlissner
Copy link
Copy Markdown
Member

mlissner commented Mar 5, 2026

LGTM.

@chaco-fl chaco-fl merged commit 28505f2 into main Mar 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants