fix: Remove internal DslObject API for Gradle 10 compatibility#1724
Open
fix: Remove internal DslObject API for Gradle 10 compatibility#1724
Conversation
The DslObject fallback in resolveSpotBugVersion() was unreachable dead code — when the SpotBugs plugin is present, its extension is always a CodeQualityExtension subclass handled by the public API path above. Replace with a simple default version fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DslObjectinternal Gradle API usage fromLombokPlugin.resolveSpotBugVersion()DslObjectfallback was unreachable dead code — when the SpotBugs plugin is present, its extension is always aCodeQualityExtensionsubclass handled by the public API pathFound during automated main branch review. The
DslObjectimport fromorg.gradle.api.internal.pluginswill break in Gradle 10.Test plan