Open
Conversation
Member
|
@lukaszb thanks for the contribution. I like the idea of adding these type of assertions but we need to make sure to catch var nilStruct struct{}
g.It("IsNil should trigger", func() {
g.Assert(nilStruct).IsNil()
})Currently this fails, It'd be nice if we could catch these scenarios also. |
Author
|
@marcosnils sure, can do that. btw, can you look at travis failed build? It seems to fail for code I haven't actually touched. |
This struct is zeroed, not nil (only pointers can be nil) so the behavior could be misleading.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.