Expose bun workspace packages as individual build targets#1654
Draft
jagonalez wants to merge 1 commit intofeat/pnpm-workspace-build-targetsfrom
Draft
Expose bun workspace packages as individual build targets#1654jagonalez wants to merge 1 commit intofeat/pnpm-workspace-build-targetsfrom
jagonalez wants to merge 1 commit intofeat/pnpm-workspace-build-targetsfrom
Conversation
- Wire FoundTargets through getDeps → analyzeBunLock → BunLock.analyze - Add resolveBunWorkspacePaths to map package names to bun workspace keys (uses "" for root instead of "." like pnpm) - Filter workspaces in buildGraph when targets are selected - Add Bun case to mkProject's build target scoping - Unit tests for workspace filtering and path resolution Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
sorry @tjugdev I was in a rush to do something and didn't mean to create a non draft pr here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveBunWorkspacePathsto map package names (build targets) to bun lockfile workspace keys (uses""for root, relative paths for members)buildGraphinBunLock.hsto accept an optional workspace filter, scoping analysis to selected workspace membersmkProjectcan be simplified in a follow-upTest plan
resolveBunWorkspacePathstests: maps root to"", workspace members to relative paths, returnsNothingforProjectWithoutTargetsbuildGraphfiltering tests: root-only filter excludes workspace deps, workspace-only filter excludes root depscabal buildsucceeds with no warnings🤖 Generated with Claude Code