Skip to content

fix: upgrade Nix flake Go version to 1.24 and fix lint errors#98

Merged
NumaryBot merged 1 commit intomainfrom
fix/upgrade-go-1.24-nix-flake
Mar 20, 2026
Merged

fix: upgrade Nix flake Go version to 1.24 and fix lint errors#98
NumaryBot merged 1 commit intomainfrom
fix/upgrade-go-1.24-nix-flake

Conversation

@flemzord
Copy link
Copy Markdown
Member

Summary

  • Bump Go version in Nix flake from 1.23 to 1.24 to match go.mod (Go 1.24.0 / toolchain go1.24.10). This was causing golangci-lint to fail with: the Go language version (go1.23) used to build golangci-lint is lower than the targeted Go version (1.24.10)
  • Update flake.lock with latest nixpkgs and NUR inputs
  • Fix staticcheck ST1001 lint errors in pkg/testserver/testserver.go by replacing dot imports with named imports

Test plan

  • just pre-commit passes locally (generate, tidy, lint — 0 issues)
  • CI pipeline passes on this PR

The Nix flake was providing Go 1.23, but go.mod targets Go 1.24.0 with
toolchain go1.24.10. This caused golangci-lint to fail because it was
built with a lower Go version than the target.

- Bump goVersion from 23 to 24 in flake.nix
- Update flake.lock with latest nixpkgs
- Replace dot imports with named imports in testserver.go (ST1001)
@flemzord flemzord requested a review from a team as a code owner March 20, 2026 08:41
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 20, 2026

Warning

Rate limit exceeded

@flemzord has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 6 minutes and 28 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6abbd09a-aea5-478e-be87-b957b23c5317

📥 Commits

Reviewing files that changed from the base of the PR and between 9fd1624 and 458d874.

⛔ Files ignored due to path filters (1)
  • flake.lock is excluded by !**/*.lock, !**/*.lock
📒 Files selected for processing (2)
  • flake.nix
  • pkg/testserver/testserver.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/upgrade-go-1.24-nix-flake
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@NumaryBot NumaryBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NumaryBot NumaryBot merged commit 0520524 into main Mar 20, 2026
6 checks passed
@NumaryBot NumaryBot deleted the fix/upgrade-go-1.24-nix-flake branch March 20, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants