Skip to content

chore: upgrade Go to 1.26#90

Merged
flemzord merged 1 commit intomainfrom
chore/upgrade-go
Mar 25, 2026
Merged

chore: upgrade Go to 1.26#90
flemzord merged 1 commit intomainfrom
chore/upgrade-go

Conversation

@sylr
Copy link
Copy Markdown
Contributor

@sylr sylr commented Mar 11, 2026

Summary

  • Upgrade Go toolchain from 1.23 to 1.26 in nix dev shell
  • Modernize flake.nix to use stable/unstable nixpkgs split
  • Use allowUnfreePredicate instead of allowUnfree = true
  • Update nix flake lock file

🤖 Generated with Claude Code

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 11, 2026

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

Updated Nix flake to use two separate nixpkgs instances (stable and unstable) instead of one, removed custom Go version overlay, and reorganized package composition to source tools from appropriate channels with selective unfree package allowance.

Changes

Cohort / File(s) Summary
Nix Flake Configuration
flake.nix
Added dual nixpkgs inputs (stable v0.2511 and unstable v0.1), updated outputs function signature to accept both packages, removed custom Go overlay, partitioned devShell composition to draw Go from stable and linting tools from unstable, changed unfree allowance to target only goreleaser-pro.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

Poem

🐰 Two nixpkgs, they now dance in tandem,
Stable and wild, a package random,
No overlay chains, just pure and clean,
The finest tooling the flake has seen! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: upgrade Go to 1.26' directly describes the main change of upgrading the Go toolchain version in the development shell, which is the primary objective.
Description check ✅ Passed The description provides relevant details about the changeset including Go upgrade, flake.nix modernization, unfree package handling changes, and lock file updates, all aligned with the actual modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/upgrade-go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sylr sylr force-pushed the chore/upgrade-go branch from 522547b to b2074e7 Compare March 20, 2026 10:10
@sylr sylr marked this pull request as ready for review March 20, 2026 10:29
@sylr sylr requested a review from a team as a code owner March 20, 2026 10:29
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@flemzord flemzord enabled auto-merge (squash) March 25, 2026 10:00
@flemzord flemzord merged commit 6edf926 into main Mar 25, 2026
5 of 6 checks passed
@flemzord flemzord deleted the chore/upgrade-go branch March 25, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants