Conversation
- Bump regions chart to v3.8.4 (ledger v2.4.2) - Fix Justfile helm-all race condition by separating dependency update (sequential) from lint/template (parallel) - Downgrade go.mod to Go 1.23.7 (Go 1.25.0 not yet released)
WalkthroughThe pull request updates Helm chart documentation versions and refactors the Justfile to optimize build execution. The Regions chart version is bumped from 3.8.3 to 3.8.4, and the ledger component from v2.4.1 to v2.4.2 across documentation. The helm-all recipe is restructured to execute dependency resolution sequentially before parallel processing, introducing helm-template-only and helm-package-only recipes to prevent race conditions. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Justfile (1)
118-131: Extract duplicated lint and library-check logic into a shared helper recipe.The lint and library-chart detection logic is duplicated across
helm-template,helm-template-only, andhelm-package-only(lines 104–116, 118–131, and 137–150). This creates maintenance burden if this logic needs updates.Additionally, both
helm-packageandhelm-package-onlypackage library charts unconditionally (lines 135 and 151). The library-chart check in these recipes only skips templating, not the actual packaging step. Verify whether library charts should be excluded from the final package output entirely.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Justfile` around lines 118 - 131, Create a shared helper recipe (e.g., helm-lint-and-check-library) that runs the yq Chart.yaml type check and helm lint, then call that helper from helm-template, helm-template-only, helm-package and helm-package-only to remove duplication; additionally, modify helm-package and helm-package-only to respect the helper's isLibrary result and skip the packaging step when isLibrary equals "library" (so library charts are not packaged), ensuring the unique recipe names helm-template, helm-template-only, helm-package and helm-package-only are updated to invoke the new helper and to conditionalize their packaging logic based on the helper's output.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@Justfile`:
- Around line 118-131: Create a shared helper recipe (e.g.,
helm-lint-and-check-library) that runs the yq Chart.yaml type check and helm
lint, then call that helper from helm-template, helm-template-only, helm-package
and helm-package-only to remove duplication; additionally, modify helm-package
and helm-package-only to respect the helper's isLibrary result and skip the
packaging step when isLibrary equals "library" (so library charts are not
packaged), ensuring the unique recipe names helm-template, helm-template-only,
helm-package and helm-package-only are updated to invoke the new helper and to
conditionalize their packaging logic based on the helper's output.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a6277996-6bc0-4311-b007-85b9ef427eef
⛔ Files ignored due to path filters (8)
charts/console-v3/Chart.lockis excluded by!**/*.lock,!**/*.lockcharts/formance/Chart.lockis excluded by!**/*.lock,!**/*.lockcharts/membership/Chart.lockis excluded by!**/*.lock,!**/*.lockcharts/portal/Chart.lockis excluded by!**/*.lock,!**/*.lockcharts/regions/Chart.yamlis excluded by!**/*.yamlcharts/regions/values.yamlis excluded by!**/*.yamltools/readme/go.modis excluded by!**/*.modtools/readme/go.sumis excluded by!**/*.sum,!**/*.sum
📒 Files selected for processing (4)
JustfileREADME.mdcharts/formance/README.mdcharts/regions/README.md
Summary
helm-allrace condition in Justfile: separate dependency update (sequential) from lint/template (parallel) to avoidtmpcharts-*conflicts on shared subchartstools/readme/go.modfrom Go 1.25.0 to Go 1.23.7 (Go 1.25 not yet released)Test plan
just pcpasses locally with no errors