Skip to content

feat: regions v3.8.4#335

Merged
flemzord merged 1 commit intomainfrom
feat+helm-regions-upgrade
Mar 26, 2026
Merged

feat: regions v3.8.4#335
flemzord merged 1 commit intomainfrom
feat+helm-regions-upgrade

Conversation

@flemzord
Copy link
Copy Markdown
Member

Summary

  • Bump regions chart to v3.8.4 (ledger v2.4.1 → v2.4.2)
  • Fix helm-all race condition in Justfile: separate dependency update (sequential) from lint/template (parallel) to avoid tmpcharts-* conflicts on shared subcharts
  • Downgrade tools/readme/go.mod from Go 1.25.0 to Go 1.23.7 (Go 1.25 not yet released)

Test plan

  • just pc passes locally with no errors
  • All 9 charts lint and template successfully

- Bump regions chart to v3.8.4 (ledger v2.4.2)
- Fix Justfile helm-all race condition by separating dependency update
  (sequential) from lint/template (parallel)
- Downgrade go.mod to Go 1.23.7 (Go 1.25.0 not yet released)
@flemzord flemzord requested a review from a team as a code owner March 25, 2026 16:32
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 25, 2026

Walkthrough

The pull request updates Helm chart documentation versions and refactors the Justfile to optimize build execution. The Regions chart version is bumped from 3.8.3 to 3.8.4, and the ledger component from v2.4.1 to v2.4.2 across documentation. The helm-all recipe is restructured to execute dependency resolution sequentially before parallel processing, introducing helm-template-only and helm-package-only recipes to prevent race conditions.

Changes

Cohort / File(s) Summary
Build Script Refactoring
Justfile
Restructured helm-all recipe to run helm-schema and helm-update sequentially per chart, then parallelize remaining operations using new helm-template-only and helm-package-only recipes that separate linting/packaging from dependency resolution.
Documentation Updates
README.md, charts/formance/README.md, charts/regions/README.md
Updated Regions chart version from 3.8.3 to 3.8.4 and ledger component version from v2.4.1 to v2.4.2 across chart documentation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

docs, release

Poem

🐰 Charts were bumped to v3 point four,
With ledgers leaping—v2 dot two, what's more!
Justfiles juggle with care,
Sequential then parallel, everywhere,
No race conditions to fight! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: regions v3.8.4' clearly reflects the main change—bumping the regions chart version to v3.8.4, which is the primary objective. It is concise, specific, and directly related to the primary change in the changeset.
Description check ✅ Passed The description is well-related to the changeset, covering the main changes: regions chart bump, Justfile race condition fix, and Go version downgrade. It includes a test plan demonstrating the changes were validated.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat+helm-regions-upgrade

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
Justfile (1)

118-131: Extract duplicated lint and library-check logic into a shared helper recipe.

The lint and library-chart detection logic is duplicated across helm-template, helm-template-only, and helm-package-only (lines 104–116, 118–131, and 137–150). This creates maintenance burden if this logic needs updates.

Additionally, both helm-package and helm-package-only package library charts unconditionally (lines 135 and 151). The library-chart check in these recipes only skips templating, not the actual packaging step. Verify whether library charts should be excluded from the final package output entirely.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@Justfile` around lines 118 - 131, Create a shared helper recipe (e.g.,
helm-lint-and-check-library) that runs the yq Chart.yaml type check and helm
lint, then call that helper from helm-template, helm-template-only, helm-package
and helm-package-only to remove duplication; additionally, modify helm-package
and helm-package-only to respect the helper's isLibrary result and skip the
packaging step when isLibrary equals "library" (so library charts are not
packaged), ensuring the unique recipe names helm-template, helm-template-only,
helm-package and helm-package-only are updated to invoke the new helper and to
conditionalize their packaging logic based on the helper's output.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@Justfile`:
- Around line 118-131: Create a shared helper recipe (e.g.,
helm-lint-and-check-library) that runs the yq Chart.yaml type check and helm
lint, then call that helper from helm-template, helm-template-only, helm-package
and helm-package-only to remove duplication; additionally, modify helm-package
and helm-package-only to respect the helper's isLibrary result and skip the
packaging step when isLibrary equals "library" (so library charts are not
packaged), ensuring the unique recipe names helm-template, helm-template-only,
helm-package and helm-package-only are updated to invoke the new helper and to
conditionalize their packaging logic based on the helper's output.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a6277996-6bc0-4311-b007-85b9ef427eef

📥 Commits

Reviewing files that changed from the base of the PR and between f7ea8c4 and d01f447.

⛔ Files ignored due to path filters (8)
  • charts/console-v3/Chart.lock is excluded by !**/*.lock, !**/*.lock
  • charts/formance/Chart.lock is excluded by !**/*.lock, !**/*.lock
  • charts/membership/Chart.lock is excluded by !**/*.lock, !**/*.lock
  • charts/portal/Chart.lock is excluded by !**/*.lock, !**/*.lock
  • charts/regions/Chart.yaml is excluded by !**/*.yaml
  • charts/regions/values.yaml is excluded by !**/*.yaml
  • tools/readme/go.mod is excluded by !**/*.mod
  • tools/readme/go.sum is excluded by !**/*.sum, !**/*.sum
📒 Files selected for processing (4)
  • Justfile
  • README.md
  • charts/formance/README.md
  • charts/regions/README.md

@flemzord flemzord enabled auto-merge (squash) March 25, 2026 16:40
@flemzord flemzord merged commit 864f8da into main Mar 26, 2026
5 checks passed
@flemzord flemzord deleted the feat+helm-regions-upgrade branch March 26, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants