fix(ui): bypass organization selection for ui command#136
fix(ui): bypass organization selection for ui command#136
Conversation
The ui command only needs server info to get the console URL, not a full organization-scoped client. Create the membership client directly to avoid forcing users through organization selection. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe UI command refactors how it constructs a membership client, replacing the interactive dialog-based approach via Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
cmd/ui/ui.goto not require organization selection for opening the console UIfctl.NewCommandinstead offctl.NewStackCommandfor the ui commandmembershipclient.New(...)to fetch server info, bypassingNewMembershipClientForOrganizationFromFlagsChanges
cmd/ui/ui.go: Changed fromfctl.NewStackCommandtofctl.NewCommand, removing the requirement for organization/stack contextcmd/ui/ui.go: Create membership client directly to get server info (console URL) without organization selectioncmd/stack/create.gochange from fix: fctl ui #115: theCreateStackResponsetype on current main still usesReadStackResponseas its field — the PR fix: fctl ui #115 change was tied to a regenerated SDK that isn't on maincmd/root.gochange from fix: fctl ui #115: theapierrors.Errortype still exists on current main, removing the case would lose error handlingTest plan
fctl uiwithout selecting an organization — should open console URL directlyfctl uistill works when authenticatedSupersedes #115
🤖 Generated with Claude Code