Skip to content

chore: replace formancehq/oidc v2 fork with go-libs/v3 oidc wrapper#121

Open
sylr wants to merge 2 commits intomainfrom
chore/oidc-v3
Open

chore: replace formancehq/oidc v2 fork with go-libs/v3 oidc wrapper#121
sylr wants to merge 2 commits intomainfrom
chore/oidc-v3

Conversation

@sylr
Copy link
Copy Markdown
Contributor

@sylr sylr commented Feb 20, 2026

No description provided.

@sylr sylr requested a review from a team as a code owner February 20, 2026 18:00
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 20, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

The import path for the oidc package in the login command was changed from github.com/zitadel/oidc/v2/pkg/oidc to github.com/formancehq/go-libs/v3/oidc. No logic, exported signatures, or behavior were altered.

Changes

Cohort / File(s) Summary
OIDC Package Import
cmd/login/login.go
Replaced oidc import path: github.com/zitadel/oidc/v2/pkg/oidcgithub.com/formancehq/go-libs/v3/oidc. No other code changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A hop, a switch, a tidy new trail,
The login code hums with a different grail,
One import swapped, everything still bright,
I hop with joy through the code tonight. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess relevance to the changeset. Add a brief description explaining the motivation for replacing the OIDC package and any migration considerations.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: replacing an OIDC package import from one source to another, which matches the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/oidc-v3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

The fixes from the formancehq/oidc fork have been upstreamed. Switch
the single direct import in cmd/login to use go-libs/v3/oidc which
re-exports the needed constants, and drop the replace directive.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gfyrag
gfyrag previously approved these changes Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants