feat: lexicon manifests property and upstream sync#89
Merged
maxine-at-forecast merged 2 commits intodevelopfrom Apr 4, 2026
Merged
feat: lexicon manifests property and upstream sync#89maxine-at-forecast merged 2 commits intodevelopfrom
maxine-at-forecast merged 2 commits intodevelopfrom
Conversation
Add shardManifestRef def and optional manifests array to science.alt.dataset.entry lexicon, aligning the JSON spec with the existing Python types (ShardManifestRef, LexDatasetEntry.manifests). Each manifest ref pairs a shard with its header blob (JSON metadata) and optional Parquet samples blob for query-based access. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace broken sync-lexicons recipe (was copying flat lexicons/*.json) with two recipes: - just sync-lexicons: fetches latest from forecast-bio/atdata-lexicon via gh API tarball, syncs to both vendored and package directories. Supports ref= parameter for pinning to a tag/branch. - just sync-lexicons-local: offline vendor→package sync (no network). Test recipe now uses sync-lexicons-local to avoid network dependency. Updated CLAUDE.md with the new commands. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shardManifestRefdef and optionalmanifestsarray toscience.alt.dataset.entrylexicon, aligning the JSON spec with existing Python types (ShardManifestRef,LexDatasetEntry.manifests)just sync-lexiconsrecipe with proper upstream fetch fromforecast-bio/atdata-lexiconviaghAPI tarballjust sync-lexicons-localfor offline vendor→package syncCloses crosslink #4, #6, #13, #14.
Test plan
just sync-lexiconsfetches from atdata-lexicon and syncs both copies🤖 Generated with Claude Code