NEW @W-21364933@ Add suppression flag for the new inline suppression markers#2006
Merged
namrata111f merged 3 commits intodevfrom Mar 20, 2026
Merged
NEW @W-21364933@ Add suppression flag for the new inline suppression markers#2006namrata111f merged 3 commits intodevfrom
namrata111f merged 3 commits intodevfrom
Conversation
1c3c28e to
db274c3
Compare
aruntyagiTutu
approved these changes
Mar 20, 2026
Contributor
aruntyagiTutu
left a comment
There was a problem hiding this comment.
config validation is not required ?
Contributor
Author
@aruntyagiTutu Config validation was added as part of the core PR: forcedotcom/code-analyzer-core#440 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the Suppression epic, we are adding inline suppression markers. This feature will add performance impact in terms of space and time. Though not significant but considerable for large code bases (few seconds ~ 4s). Hence we want to only enable it for the users who want to particularly use it.
Tested following cases:
Case-1) When only --no-suppression flag is passed from cli. The violations are not suppressed:
Case-2) When default values are used. Violations are suppressed:
Case-3) When cli passes the --no-suppression flag but the config yml has it disabled, suppressions are honored:
Case-4) When the flag is set false from config yaml: