NEW @W-20485780@ - Add Fixes and Suggestions to the Engine APITask Description#438
Merged
aruntyagiTutu merged 5 commits intodevfrom Mar 20, 2026
Merged
Conversation
Contributor
|
Contributor
|
Are there any performance benchmarks or limits? |
Contributor
Author
refer to this PR : #441 the include fixes and suggestions will be passed on to the respective engines where the decision is made |
Contributor
Author
currently only eslint provides fixes and suggestions [already providing we are just not using it as of now] so no changes on the performance that i can see once apex guru comes in we do need to do some benchmarking |
packages/code-analyzer-core/src/output-formats/results/sarif-run-results-format.ts
Show resolved
Hide resolved
namrata111f
reviewed
Mar 18, 2026
aruntyagiTutu
approved these changes
Mar 20, 2026
namrata111f
approved these changes
Mar 20, 2026
nikhil-mittal-165
force-pushed
the
feature/fixes-suggestion-data-modelling
branch
4 times, most recently
from
a7b0ce9 to
39bfe73
Compare
Define Fix and Suggestion types in engine-api, add core interfaces and implementations, update JSON/SARIF/XML output formats, and pass includeFixes/includeSuggestions flags through RunOptions to all engines.
nikhil-mittal-165
force-pushed
the
feature/fixes-suggestion-data-modelling
branch
from
39bfe73 to
d2be5ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@W-20485780@ -
Define Fix and Suggestion types in engine-api, add core interfaces and implementations, update JSON/SARIF/XML output formats, and pass includeFixes/includeSuggestions flags through RunOptions to all engines.