fix(image): reset hidden state when buffer becomes visible again#2793
Open
shy-robin wants to merge 1 commit intofolke:mainfrom
Open
fix(image): reset hidden state when buffer becomes visible again#2793shy-robin wants to merge 1 commit intofolke:mainfrom
shy-robin wants to merge 1 commit intofolke:mainfrom
Conversation
When switching away from an image buffer, `update()` calls `hide()` which sets `self.hidden = true`. When switching back, `update()` is triggered via BufEnter/BufWinEnter autocmds, but `self.hidden` is never reset to `false`. This causes `_render()` to produce empty extmarks, leaving the image invisible. Reset `self.hidden = false` when `update()` detects visible windows (`#state.wins > 0`), so the image re-renders correctly on buffer re-entry. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When switching away from an image buffer,
placement:update()callshide()which setsself.hidden = true. When switching back,update()is triggered viaBufEnter/BufWinEnterautocmds, butself.hiddenis never reset tofalse. This causes_render()to produce empty extmarks, leaving the image invisible (stuck showing "identify loading…" or blank).Steps to reproduce:
Fix: Reset
self.hidden = falsewhenupdate()detects visible windows (#state.wins > 0), so the image re-renders correctly on buffer re-entry.Test plan