Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a race condition in ChunkStream where the chunker's internal backing buffer could be overwritten by fillBuffer() before workers finished processing the slice sent through the channel. This caused
desync tar -ito write chunks whose content didn't match their filename hash, producing stores that fail verification.The bug was introduced in #307 which optimized fillBuffer() to reuse a backing buffer instead of allocating a fresh one each call. Single-threaded callers (like IndexFromFile) were unaffected since they hash the slice before the next Next() call, but ChunkStream sends the slice to worker goroutines via a channel.
Fixes #313