Allow configuration of invoke URL pattern via environment variables#1400
Open
Allow configuration of invoke URL pattern via environment variables#1400
Conversation
d87897a to
6690cb8
Compare
4d0f969 to
5e82eaa
Compare
ab3c0f2 to
5e82eaa
Compare
Contributor
|
hmm. we have methods to add endpoints to the server itself and we have handlers (the invoke handler which uses the same var), so while this solves the problem I'm not sure we need the additional configurations and code and this could be a one liner in the configuration of fn? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue this resolves
What I did
This allows for an Fn server to customize the path of the invoke URLs it handles
There are two new environment variables for configuration:
FN_INVOKE_GROUP represents the static prefix of the invoke endpoints
FN_INVOKE_TEMPLATE represents the URL path and should include
:fn_idto represent the function IDRun an Fn server with
FN_INVOKE_GROUP=/runthefunctionandFN_INVOKE_TEMPLATE=/:fn_id/prettypleaseDeploy a function.
Run
curl http://127.0.0.1:8080/runthefunction/<function_id>/prettypleaseAllow configuration of invoke URL pattern via environment variables