Fix run_sync failure when called from a running event loop#3407
Open
pingsutw wants to merge 1 commit intoflyteorg:masterfrom
Open
Fix run_sync failure when called from a running event loop#3407pingsutw wants to merge 1 commit intoflyteorg:masterfrom
pingsutw wants to merge 1 commit intoflyteorg:masterfrom
Conversation
When `run_sync` is called from within an already-running async event loop (e.g., Flask/Gunicorn), the `_TaskRunner` approach fails with "Cannot run the event loop while another loop is running". This detects the running loop and instead spawns a short-lived thread with its own event loop via `asyncio.run()`, preserving context variables. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Kevin Su <pingsutw@apache.org>
pingsutw
requested review from
cosmicBboy,
davidmirror-ops,
kumare3,
machichima,
samhita-alla and
wild-endeavor
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RuntimeError: Cannot run the event loop while another loop is runningwhenFlyteRemote.execute()is called from within an already-running async event loop (e.g., Flask with Gunicorn)_AsyncLoopManager.run_sync()now detects a running loop and spawns a short-lived thread with its own event loop viaasyncio.run(), preserving context variables withcontextvars.copy_context()_TaskRunnerpath remains unchanged for non-async contextsTest plan
test_run_sync_from_running_event_loop— verifiesrun_syncworks when called from within a running event looptest_run_sync_from_running_event_loop_with_exception— verifies exceptions propagate correctly in this pathtests/flytekit/unit/utils/test_asyn.pypass (8/8)