Draft
Conversation
Encapsulated under fluxcd/pkg/runtime/events Signed-off-by: Adrian Fernandez De La Torre <adri1197@gmail.com>
ce078d3 to
f2799fb
Compare
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the source-controller event recorder from
event/v1beta1toevent/v1, using the events.EventRecorder interface fromfluxcd/pkg/runtime/events.Changes
k8s.io/client-go/tools/record.EventRecorderwithfluxcd/pkg/runtime/events.EventRecorderacross all controllers and the summarize package.fluxcd/pkg/apis/event/v1beta1tofluxcd/pkg/apis/event/v1.Motivation
The
event/v1beta1API is being deprecated in favor ofevent/v1.Closes fluxcd/flux2#5761