add optional wait_status to exception event to inform finish event status#504
Merged
mergify[bot] merged 3 commits intoflux-framework:masterfrom Mar 20, 2026
Merged
Conversation
Problem: When a severity 0 exception is raised on a job, the subsequent job cleanup may shadow an abnormal exit status that caused the exception, for example if a task gets a segfault and exit-on-error is set. Add an optional wait_status field to exception events to capture any relevant abnormal wait status that should be preserved in the eventlog.
grondo
force-pushed
the
exception-status
branch
from
dc9d683 to
dc4e37f
Compare
|
|
1 similar comment
|
|
Problem: An exception event wait_status is proposed as a way to override the default computation of the finish event status as the maximum of all shell wait status codes, but this is not codified in the finish event status field description in RFC 21. Require that a severity 0 exception with a wait_status field be used to derive the finish event status when present.
Problem: RFC 21 requires that the finish event status field be derived from the exception wait_status field if present, but RFC 32 does not call this out for the exec system finish response. Amend the finish response with the updated requirements.
grondo
force-pushed
the
exception-status
branch
from
dc4e37f to
7f4b52a
Compare
|
|
Contributor
Merge Queue Status
This pull request spent 5 seconds in the queue, with no time running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an optional
wait_statusfield toexceptionevents, meant to be used by the job shell to force afinisheventstatusvalue when job cleanup triggered by the exception could end up masking a more important exit status. (E.g. when a single task segfaults andexit-on-erroris set).This is just a proposal for discussion at this point. Happy to investigate other approaches!