rfc3: fix message framing length description and define USER1 message flag#502
Merged
mergify[bot] merged 3 commits intoflux-framework:masterfrom Mar 6, 2026
Merged
Conversation
Problem: the API defines FLUX_MSGFLAG_USER1 as 0x80, and this is used in the content cache implementation, but RFC 3 leaves this flag bit undefined, inviting it to be co-opted for incompatible purposes. Define the user1 flag in the ABNF. Fixes flux-framework#498
Problem: the figure depicting message framing for messages passed over the local connector has an incorrect message length. The length is shown as 0x25 (37 bytes), but the sum of the payload fields is 0x31 (49 bytes) and the size and magic fields (8 bytes) are excluded, in conflict with the current implementation. Update the the length field in the figure to 0x39 (57 bytes) so that it reflects the actual payload length, plus the size of the length and magic fields. Regenerate the png from the dia source.
Problem: RFC 3 specifies the message length for messages framed for transmission over UNIX domain sockets as sum of the payload frames, but the implementation includes the length field itself and the magic field. Update RFC 3 so that it matches the implementation. Fixes flux-framework#496
|
|
Member
Author
|
Thanks! Setting MWP. |
Contributor
Merge Queue StatusRule:
This pull request spent 39 seconds in the queue, with no time running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This corrects some errors and omissions in RFC 3.
Thanks to @manorom for catching the length issue in #496