Skip to content

rfc18: reference the JSON Lines specification#501

Merged
mergify[bot] merged 1 commit intoflux-framework:masterfrom
garlick:json_lines
Mar 6, 2026
Merged

rfc18: reference the JSON Lines specification#501
mergify[bot] merged 1 commit intoflux-framework:masterfrom
garlick:json_lines

Conversation

@garlick
Copy link
Member

@garlick garlick commented Mar 6, 2026

Problem: it turns out that Flux eventlogs conform to the JSON lines specification, which could be useful information, but it is not referenced in RFC 18.

Add a reference.

Fixes #212

@github-actions
Copy link

github-actions bot commented Mar 6, 2026

⚠️ linkcheck failed with status code 2

Copy link
Contributor

@grondo grondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@garlick
Copy link
Member Author

garlick commented Mar 6, 2026

It was your catch (in 2019) :-) Setting MWP.

@mergify
Copy link
Contributor

mergify bot commented Mar 6, 2026

Merge Queue Status

Rule: default


  • Entered queue2026-03-06 16:02 UTC
  • 🚫 Left the queue2026-03-06 16:52 UTC · at 653d36dcdbcf4e17d391612dbe4eccb52af2cf5e

This pull request spent 50 minutes 38 seconds in the queue, with no time running CI.

Reason

The pull request can't be updated

rebase not prepared

Hint

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

@mergify mergify bot added dequeued and removed queued labels Mar 6, 2026
Problem: it turns out that Flux eventlogs conform to the JSON lines
specification, which could be useful information, but it is not
referenced in RFC 18.

Add a reference.

Fixes flux-framework#212
@garlick
Copy link
Member Author

garlick commented Mar 6, 2026

rebased and forced a push to kick mergify

@mergify mergify bot removed the dequeued label Mar 6, 2026
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

⚠️ linkcheck failed with status code 2

@mergify mergify bot added the queued label Mar 6, 2026
@mergify mergify bot merged commit 2f90ad6 into flux-framework:master Mar 6, 2026
6 of 7 checks passed
@mergify
Copy link
Contributor

mergify bot commented Mar 6, 2026

Merge Queue Status

Rule: default


  • Entered queue2026-03-06 17:03 UTC
  • Checks passed · in-place
  • Merged2026-03-06 17:03 UTC · at 55947e07cb63065c6bca1f47fb61a0c129297649

This pull request spent 5 seconds in the queue, with no time running CI.

Required conditions to merge
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:flux-rfc
    • check-neutral = docs/readthedocs.org:flux-rfc
    • check-skipped = docs/readthedocs.org:flux-rfc
  • any of [🛡 GitHub branch protection]:
    • check-success = make check
    • check-neutral = make check
    • check-skipped = make check
  • any of [🛡 GitHub branch protection]:
    • check-success = validate commits
    • check-neutral = validate commits
    • check-skipped = validate commits

@mergify mergify bot removed the queued label Mar 6, 2026
@garlick garlick deleted the json_lines branch March 6, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC 18: reference JSON lines "spec"?

2 participants