Open
Conversation
chu11
force-pushed
the
rfc21_reattach_state
branch
from
387543a to
cb444d6
Compare
Member
|
Quick comment: maybe the state should be DETACHED and the events should be My only misgiving about that name is it might be confused with What about OFFLINE with events |
chu11
force-pushed
the
rfc21_reattach_state
branch
from
cb444d6 to
755fabf
Compare
chu11
force-pushed
the
rfc21_reattach_state
branch
from
755fabf to
b9550e8
Compare
Member
Author
|
re-pushed, i went with the suggested "offline" nomenclature above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a first cut at the addition of a "reattach" state to the job state. "reattach" word choice can be debated of course.
My knowledge of dot is not immense, but I appear to have got something that looks pretty :P.