Conversation
leehack
requested review from
aliyazdi75 and
kezfran
and removed request for
a team
| imageUrl: | ||
| 'https://i1.wp.com/www.suitcasescholar.com/wp-content/uploads/2012/08/DSC_2583.jpg', | ||
| ), | ||
| imageFile: File( |
There was a problem hiding this comment.
The code here doesn't work.
Probably we want to pass bytes instead of File once we read it from the image picker.
@aliyazdi75 @billyandco What do you guys think?
There was a problem hiding this comment.
One more thing to consider.
Should we separate the image upload and posting in the UI? or do it together?
Should we better create an upload method in postingRepository or does the add method do both?
There was a problem hiding this comment.
Yes, I think we need to pass the bytes instead.
| final Reference storageRef; | ||
|
|
||
| @override | ||
| Stream<FirestorageEvent> upload(File image) { |
There was a problem hiding this comment.
This needs to be implemented properly. I'm thinking of creating a type for the argument that contains metadata + filepath or byte array of the file.
@aliyazdi75 @billyandco What do you guys think?
There was a problem hiding this comment.
Yes I think keeping metadata is useful and byte array.
2 participants
TODO: