COM-14536 - videocodectestsink errors in Y42B with GStreamer=1.20.x#343
Open
rsanchez87 wants to merge 1 commit intomasterfrom
Open
COM-14536 - videocodectestsink errors in Y42B with GStreamer=1.20.x#343rsanchez87 wants to merge 1 commit intomasterfrom
rsanchez87 wants to merge 1 commit intomasterfrom
Conversation
rsanchez87
changed the title
rsanchez87
changed the title
rsanchez87
changed the title
| self.decoder_bin, | ||
| caps, | ||
| self.sink, | ||
| self._get_sink_for_format(output_format), |
Contributor
There was a problem hiding this comment.
You are replacing the sink inside gen_pipeline and inside decode.
IMHO Doing it in just one place is enough.
Contributor
Author
There was a problem hiding this comment.
More above something like?:
def _get_sink_for_format(self, output_format: OutputFormat) -> str: # pylint: disable=unused-argument
return self.sink
and...
if self._get_sink_for_format(output_format) == "videocodectestsink": ?
removing decode
fluster/decoders/gstreamer.py
Outdated
| """Decode the test vector and do the checksum.""" | ||
| original_sink = self.sink | ||
| self.sink = self._get_sink_for_format(output_format) | ||
| try: |
Contributor
There was a problem hiding this comment.
is this try needed?
Contributor
Author
There was a problem hiding this comment.
No, with previous changes
…ith GStreamer 1.20.3 - videocodectestsink did not support YUV422 formats (Y42B, I422_10LE, I422_12LE) until GStreamer 1.22.0 (MR !3331). On GStreamer 1.20.x - Detect the installed GStreamer version at runtime and fall back to filesink for those formats when the version is older than 1.22.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Test vectors with YUV422 output format (
yuv422p,yuv422p10le,yuv422p12le) fail on GStreamer 1.20.x:videocodectestsinkonly gained YUV422 support in GStreamer 1.22.0(MR !3331).
Verification