Open
Conversation
rgonzalezfluendo
requested changes
Mar 20, 2026
Contributor
rgonzalezfluendo
left a comment
rgonzalezfluendo
left a comment
There was a problem hiding this comment.
We can not use parsebin with h266 for all the decoders. Note #312
The correcto solution is using GST_PLUGIN_FEATURE_RANK to promote decoder to test.
carlosfg-flu
force-pushed
the
OCP-7503_h266_use_parsebin
branch
from
fc1b1b5 to
a62026e
Compare
carlosfg-flu
force-pushed
the
OCP-7503_h266_use_parsebin
branch
from
a62026e to
39b147f
Compare
fluster/decoders/gstreamer.py
Outdated
| # GStreamer has, like when "parsebin" set its caps based on the first | ||
| # decoder it found | ||
| current_feat_rank = self.extra_env.get("GST_PLUGIN_FEATURE_RANK", "") | ||
| self.extra_env["GST_PLUGIN_FEATURE_RANK"] = f"{self.decoder_bin}:MAX,{current_feat_rank}" |
Contributor
There was a problem hiding this comment.
Unfortunately self.decoder_bin is can has values as
avdec_mpeg2video(where trim is needed)fluaacdec trim=0vulkanvp9dec ! vulkandownload(where vulkanvp9dec or both must have MAX rank)
Where env must be like:
avdec_mpeg2video:MAXfluaacdec:MAXvulkanvp9dec:MAX,vulkandownload:MAX
Contributor
Author
There was a problem hiding this comment.
I've stepped back here. I've set GST_PLUGIN_FEATURE_RANK only in FluendoVVCdeCH266Decoder. For simplicity's sake.
Contributor
There was a problem hiding this comment.
IMHO: Let's do the extra mile to implement a generic solution.
You can assume the decoder is the the first word of the bin string. (We don't need to promote extra elements as vulkandownload)
carlosfg-flu
force-pushed
the
OCP-7503_h266_use_parsebin
branch
5 times, most recently
from
acd1410 to
dce8754
Compare
Add a "extra_env" argument to run_command() and run_command_with_output() that allows to extend its environment. Issue: OCP_7503
Use GST_PLUGIN_FEATURE_RANK for setting the rank of the decoder being tested to maximun so it avoid issues like in 654b042 Issue: OCP_7503
This cleaner and allows to use other parsers rather than "h266parse". Issue: OCP_7503
carlosfg-flu
force-pushed
the
OCP-7503_h266_use_parsebin
branch
from
dce8754 to
8d72754
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleaner and allows to use other parsers rather than "h266parse".
Issue: OCP_7503