Skip to content

Drop -Gst1.0 suffix from GStreamer decoder and other GStreamer references#313

Merged
rgonzalezfluendo merged 1 commit intomasterfrom
drop_gst1.0_suffix
Mar 20, 2026
Merged

Drop -Gst1.0 suffix from GStreamer decoder and other GStreamer references#313
rgonzalezfluendo merged 1 commit intomasterfrom
drop_gst1.0_suffix

Conversation

@rgonzalezfluendo
Copy link
Contributor

The first commit drops all the references to 1.0 when GStreamer was supported. These references come from when GStreamer 1.0 and the legacy GStreamer 0.10 were supported.

This is a BREAKING CHANGE: Decoder names change, losing the -Gst1.0 prefix.

The second commit adds a workaround to avoid breaking the BC waiting for the next major release.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the GStreamer decoder naming by removing legacy version suffixes that originated from when both GStreamer 0.10 and 1.0 were supported. Since only GStreamer 1.0+ is now supported, the -Gst1.0 suffix is no longer meaningful.

Key changes:

  • Decoder names are simplified by removing the -Gst1.0 suffix (BREAKING CHANGE)
  • A temporary backward compatibility workaround is added to handle old decoder names until version 1.0.0
  • Documentation and references updated to remove "1.0" version specifications

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
fluster/fluster.py Adds backward compatibility logic to strip -gst1.0 suffix from decoder names
fluster/decoders/gstreamer.py Refactors all GStreamer decoder classes, removing version suffixes from names and consolidating base class properties
Makefile Updates test commands to use new decoder names without -Gst1.0 suffix

@mdimopoulos mdimopoulos force-pushed the drop_gst1.0_suffix branch 2 times, most recently from a67cb5d to 572ebc9 Compare December 10, 2025 10:53
Copy link
Contributor

@ylatuya ylatuya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please

Removes explicit references to GStreamer 1.0 throughout the
codebase. These references date back to when Fluster supported
Gstreamer 1.0 and 0.10. They no longer contribute anything.

FUTURE BREAKING CHANGE: Decoder names will lose the 'Gst1.0' prefix.
A temporary workaround has been implemented to maintain backward
compatibility for the current release.

NOTE: This workaround must be removed in the next MAJOR version update.
@rgonzalezfluendo rgonzalezfluendo merged commit 28eb8c5 into master Mar 20, 2026
4 checks passed
@rgonzalezfluendo rgonzalezfluendo deleted the drop_gst1.0_suffix branch March 20, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants