fix: narrow Wall velocity validation errors#1984
Open
benflexcompute wants to merge 1 commit intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WallRotation.angular_velocityso its field metadata is treated as a description instead of a default valueWall.velocitydict inputs through the tagged wall-velocity models before the tuple branch is attemptedWallRotation.angular_velocityWhy
Missing
WallRotation.angular_velocitycurrently produces noisy validation output:Wall.velocityis a union withVelocityVectorType, so dict inputs also leak tuple/validator branch errors that are irrelevant oncetype_namealready points toWallRotationValidation
python -m py_compile flow360/component/simulation/models/surface_models.py tests/simulation/params/test_rotation.pyHOME=/tmp MPLCONFIGDIR=/tmp/matplotlib /disk2/ben/SchemaMigration/Flow360/.venv/bin/python3 -m pytest -c tests/pytest.ini -rA tests/simulation/params/test_rotation.py -k 'wall_angular_velocity or missing_angular_velocity'Note
Low Risk
Low risk: changes only Pydantic field metadata and pre-validation for
Wall.velocity, primarily affecting error reporting and dict parsing rather than solver translation logic.Overview
Fixes
WallRotation.angular_velocityso itsFieldstring is treated as a description (not a default), restoring correct “Field required” behavior when missing.Adds a
velocitypre-validator onWallthat routes dict inputs withtype_namethrough aTypeAdapterfor tagged wall-velocity models, preventing noisy union/tuple-branch validation errors. Includes a regression test asserting the narrowed validation output for missingangular_velocity.Reviewed by Cursor Bugbot for commit 849b04b. Bugbot is set up for automated code reviews on this repo. Configure here.