Skip to content

tests: Drop screenshots from metainfo#714

Merged
bbhtt merged 1 commit intomainfrom
bbhtt/drop-user-install
Mar 10, 2026
Merged

tests: Drop screenshots from metainfo#714
bbhtt merged 1 commit intomainfrom
bbhtt/drop-user-install

Conversation

@bbhtt
Copy link
Contributor

@bbhtt bbhtt commented Mar 10, 2026

This aren't required since the test is checking for the presence
of a mirrored icon link. Appstream tries to download screenshots
if present and ignores download failures anyway silently. This may be
contributing to the flakiness in 1. Since the test already works
offline, the screenshot links are redundant

@bbhtt
Copy link
Contributor Author

bbhtt commented Mar 10, 2026

nevermind...

@bbhtt
Copy link
Contributor Author

bbhtt commented Mar 10, 2026

ah looks like it's appstream somehow sometimes getting stuck.

2026-03-10T15:37:36.4005207Z Running appstreamcli compose
2026-03-10T15:37:36.4005730Z Saving screenshots in /var/tmp/test-flatpak-5zTxki/.fp-compose-url-policy-full/rofiles/rofiles-rz1f56/files/share/app-info/media
2026-03-10T15:37:36.4006452Z Only accepting components: org.flatpak.appstream_media, org.flatpak.appstream_media.desktop
2026-03-10T15:37:36.4007103Z Processing directory: /var/tmp/test-flatpak-5zTxki/.fp-compose-url-policy-full/rofiles/rofiles-rz1f56/files
2026-03-10T15:37:36.4007722Z Composing metadata...
2026-03-10T15:37:36.4007909Z OK closing connection
2026-03-10T15:37:36.4008077Z Terminated
2026-03-10T15:37:36.4008526Z rm: cannot remove '/var/tmp/test-flatpak-5zTxki/.fp-compose-url-policy-full/rofiles/rofiles-rz1f56': Device or resource busy

This aren't required since the test is checking for the presence
of a mirrored icon link. Appstream tries to download screenshots
if present and ignores download failures anyway silently. This may be
contributing to the flakiness in [1]. Since the test already works
offline, the screenshot links are redundant

[1]: #714 (comment)
@bbhtt bbhtt force-pushed the bbhtt/drop-user-install branch from fb475ef to f4d6b61 Compare March 10, 2026 15:58
@bbhtt bbhtt changed the title tests: Tweak install tests to use flatpak-repo instead of install tests: Drop screenshots from metainfo Mar 10, 2026
@bbhtt bbhtt merged commit 0e9e1b3 into main Mar 10, 2026
3 checks passed
@bbhtt bbhtt deleted the bbhtt/drop-user-install branch March 10, 2026 16:03
@bbhtt bbhtt added this to the 1.5.0 milestone Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant