Conversation
Contributor
Author
|
nevermind... |
Contributor
Author
|
ah looks like it's appstream somehow sometimes getting stuck. |
This aren't required since the test is checking for the presence of a mirrored icon link. Appstream tries to download screenshots if present and ignores download failures anyway silently. This may be contributing to the flakiness in [1]. Since the test already works offline, the screenshot links are redundant [1]: #714 (comment)
fb475ef to
f4d6b61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aren't required since the test is checking for the presence
of a mirrored icon link. Appstream tries to download screenshots
if present and ignores download failures anyway silently. This may be
contributing to the flakiness in 1. Since the test already works
offline, the screenshot links are redundant